Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension viewlet button focus looks odd #59397

Closed
miguelsolorio opened this issue Sep 25, 2018 · 0 comments
Closed

Extension viewlet button focus looks odd #59397

miguelsolorio opened this issue Sep 25, 2018 · 0 comments
Assignees
@miguelsolorio
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded
Milestone
October 2018

Comments

@miguelsolorio
Copy link
Contributor

It appears that the outline width is set to 2px (which is bigger than our default)
https://github.com/Microsoft/vscode/blob/beebc71b13a0f6dac7a272f12ed30580ee510cf9/src/vs/workbench/parts/extensions/electron-browser/media/extensionActions.css#L9

Which causes focus to look odd
image

This should be removed since we already define that.
@miguelsolorio miguelsolorio added bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions labels Sep 25, 2018
@miguelsolorio miguelsolorio self-assigned this Sep 25, 2018
@miguelsolorio miguelsolorio added this to the October 2018 milestone Oct 3, 2018
@RMacfarlane RMacfarlane added the verified Verification succeeded label Oct 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@miguelsolorio miguelsolorio

Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded
Projects
None yet
Milestone
October 2018
Development

No branches or pull requests
2 participants
@RMacfarlane @miguelsolorio