Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to install extension #59429

Closed
roblourens opened this issue Sep 26, 2018 · 4 comments
Closed

Failed to install extension #59429

roblourens opened this issue Sep 26, 2018 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded

Comments

@roblourens
Copy link
Member

roblourens commented Sep 26, 2018

I tried to install an extension (zignd.html-css-class-completion) and got this error. It worked the second time.

Maybe this is just a weird fluke but in case it's helpful at all, here's a stack...

TypeError: Cannot read property 'identifier' of undefined
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:3868:856
    at Array.filter (<anonymous>)
    at e.checkAndEnableDisabledDependencies (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:3868:800)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:3867:500
    at Object.g [as _notify] (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:159:729)
    at Object.enter (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:163:61)
    at n.Class.derive._creator._run (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:164:902)
    at n.Class.derive._creator._completed (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:164:343)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions labels Sep 26, 2018
@sandy081 sandy081 added this to the September 2018 milestone Sep 26, 2018
@sandy081
Copy link
Member

It's a timing issue and hard to repro. Please try installing above extension multiple times and make sure you do not see this error.

@octref
Copy link
Contributor

octref commented Sep 27, 2018

@sandy081 I don't think that would repro this case, because you added mechanism to not really delete an extension for uninstall, so you can bring it back instantly when reinstalling. Correct?

@octref
Copy link
Contributor

octref commented Sep 27, 2018

Anyway I ran rm -rf for the extension and reinstalled successfully for a few times.

@octref octref added the verified Verification succeeded label Sep 27, 2018
@sandy081
Copy link
Member

@octref This is nothing to do with removing the extension from disk or not. Its purely a communication timing issue between renderer and shared process. I can explain to you if wanted.

But I think your way of verification is also sufficient.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants