Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening settings editor should always focus search input field #59444

Closed
bpasero opened this issue Sep 26, 2018 · 3 comments
Closed

Opening settings editor should always focus search input field #59444

bpasero opened this issue Sep 26, 2018 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality settings-editor VS Code settings editor issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Sep 26, 2018

Steps to Reproduce:

  1. open settings editor
  2. search for a setting
  3. change a setting
  4. close settings editor
  5. open settings editor

=> 馃悰 it may be questionable to restore all the view state, not sure I like that. but for sure the focus should return to the input field so that I can just start typing. ideally the text in the input field is also fully pre-selected to that I can quickly clear the results.

@roblourens
Copy link
Member

I changed this on purpose for this scenario

  • Change a setting
  • Ctrl+tab to another editor
  • Ctrl+tab back, I want focus to be on the same setting

#57640

We still can't tell the difference between closing an editor and just switching away to another tab right?

@roblourens roblourens added feature-request Request for new features or functionality settings-editor VS Code settings editor issues labels Sep 26, 2018
@roblourens
Copy link
Member

Maybe cmd+,, the menu item, etc can open the settings UI then focus the search input. Then if you open it that way, we focus the search input, but if you ctrl+tab or click the tab to open it, we keep the current behavior.

@bpasero
Copy link
Member Author

bpasero commented Sep 27, 2018

We still can't tell the difference between closing an editor and just switching away to another tab right?

The input would get a call to close() upon closing and emits a onDidDispose() event if that helps.

@roblourens roblourens added this to the October 2018 milestone Sep 27, 2018
@roblourens roblourens added the verification-needed Verification of issue is requested label Dec 4, 2018
@bpasero bpasero added the verified Verification succeeded label Dec 4, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality settings-editor VS Code settings editor issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants