Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read property 'lineNumber' of null #59451

Closed
isidorn opened this issue Sep 26, 2018 · 2 comments
Closed

Cannot read property 'lineNumber' of null #59451

isidorn opened this issue Sep 26, 2018 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-hover Editor mouse hover verified Verification succeeded

Comments

@isidorn
Copy link
Contributor

isidorn commented Sep 26, 2018

  1. Have the follwoing program
console.log('hello')
debugger
  1. Hover over console -> you get a debug hover, now put the mouse over the debug hover
  2. Notice error in console
Cannot read property 'lineNumber' of null: TypeError: Cannot read property 'lineNumber' of null
	at Object.to (/Users/isidor/Development/vscode/out/vs/workbench/api/node/extHostTypeConverters.js:66:48)
	at HoverAdapter.provideHover (/Users/isidor/Development/vscode/out/vs/workbench/api/node/extHostLanguageFeatures.js:170:44)
	at /Users/isidor/Development/vscode/out/vs/workbench/api/node/extHostLanguageFeatures.js:852:96
	at ExtHostLanguageFeatures._withAdapter (/Users/isidor/Development/vscode/out/vs/workbench/api/node/extHostLanguageFeatures.js:784:20)
	at ExtHostLanguageFeatures.$provideHover (/Users/isidor/Development/vscode/out/vs/workbench/api/node/extHostLanguageFeatures.js:852:25)
	at RPCProtocol._doInvokeHandler (/Users/isidor/Development/vscode/out/vs/workbench/services/extensions/node/rpcProtocol.js:391:27)
	at RPCProtocol._invokeHandler (/Users/isidor/Development/vscode/out/vs/workbench/services/extensions/node/rpcProtocol.js:376:54)
	at RPCProtocol._receiveRequest (/Users/isidor/Development/vscode/out/vs/workbench/services/extensions/node/rpcProtocol.js:300:32)
	at RPCProtocol._receiveOneMessage (/Users/isidor/Development/vscode/out/vs/workbench/services/extensions/node/rpcProtocol.js:235:26)
	at /Users/isidor/Development/vscode/out/vs/workbench/services/extensions/node/rpcProtocol.js:114:69
	at /Users/isidor/Development/vscode/out/vs/base/common/event.js:456:70
	at Emitter.fire (/Users/isidor/Development/vscode/out/vs/base/common/event.js:151:38)
	at acceptChunk (/Users/isidor/Development/vscode/out/vs/base/parts/ipc/node/ipc.net.js:104:46)
	at Socket.Protocol.Protocol.firstDataChunk._socketDataListener (/Users/isidor/Development/vscode/out/vs/base/parts/ipc/node/ipc.net.js:130:17)
	at emitOne (events.js:116:13)
	at Socket.emit (events.js:211:7)
	at addChunk (_stream_readable.js:263:12)
	at readableAddChunk (_stream_readable.js:250:11)
	at Socket.Readable.push (_stream_readable.js:208:10)
	at Pipe.onread (net.js:594:20)

Note that I am properly returing a position in my debugHover here
@jrieken might you have the clue what is the issue here

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug editor-hover Editor mouse hover labels Sep 26, 2018
@jrieken
Copy link
Member

jrieken commented Sep 26, 2018

@isidorn this means someone requests the hover without providing a position. I am pretty sure this is debugging itself, via this https://github.com/Microsoft/vscode/blob/200d30e467f9020cc2de8c5cbb2cb2c1fd1831ce/src/vs/workbench/parts/debug/electron-browser/debugEditorContribution.ts#L418

@jrieken jrieken removed their assignment Sep 26, 2018
@isidorn
Copy link
Contributor Author

isidorn commented Sep 26, 2018

@jrieken thanks! You were correct I was wrongly requesting the hover

@isidorn isidorn added this to the September 2018 milestone Sep 26, 2018
@sandy081 sandy081 added the verified Verification succeeded label Sep 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-hover Editor mouse hover verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants