Ctrl/cmd + f in terminal find widget should be a no-op #59785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
reviewed
Oct 5, 2018
| @@ -465,6 +465,9 @@ actionRegistry.registerWorkbenchAction(new SyncActionDescriptor(RenameTerminalAc | |||
| actionRegistry.registerWorkbenchAction(new SyncActionDescriptor(FocusTerminalFindWidgetAction, FocusTerminalFindWidgetAction.ID, FocusTerminalFindWidgetAction.LABEL, { | |||
| primary: KeyMod.CtrlCmd | KeyCode.KEY_F | |||
| }, KEYBINDING_CONTEXT_TERMINAL_FOCUS), 'Terminal: Focus Find Widget', category); | |||
| actionRegistry.registerWorkbenchAction(new SyncActionDescriptor(FocusTerminalFindWidgetAction, FocusTerminalFindWidgetAction.ID, FocusTerminalFindWidgetAction.LABEL, { | |||
| primary: KeyMod.CtrlCmd | KeyCode.KEY_F | |||
| }, KEYBINDING_CONTEXT_TERMINAL_FIND_WIDGET_FOCUSED), 'Terminal: Focus Find Widget', category); | |||
There was a problem hiding this comment.
Was KEYBINDING_CONTEXT_TERMINAL_FOCUS not true when the find widget is focused? This will cause problems for users who want to configure custom keybindings with terminalFocus
There was a problem hiding this comment.
KEYBINDING_CONTEXT_TERMINAL_FOCUS does not appear to be true when the find widget is focused. What kinds of problems will this cause for custom keybindings?
There was a problem hiding this comment.
Maybe it's not such a big issue, it's just people will assume that terminalFocus means that the terminal panel is focused, not just the actual terminal. Anyway, if that is a problem we can fix it when we get to it 😃
alexr00
changed the title
Tyriar
approved these changes
Oct 10, 2018
alexr00
force-pushed
the
alexr00/doubleCtrlF
branch
from
7f6a242
to
2ad2df8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59317