Don't include extension actions in tab order until focused #59861
Conversation
|
@ramya-rao-a I am not a big fan of having two different UI / Keyboard navigation based on accessibility is enabled or not. I agree that not showing install actions is not good. I would rather fix keyboard navigation to be similar always like the better workaround we discussed here. |
ramya-rao-a
force-pushed
the
ramyar/extension-actions-taborder
branch
from
80d78db
to
79480ec
Compare
ramya-rao-a
changed the title
ramya-rao-a
force-pushed
the
ramyar/extension-actions-taborder
branch
from
79480ec
to
ed4aa84
Compare
|
@sandy081 PR is updated as per prior discussions. See |
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
@sandy081 DropDownMenuActionItem is used for Enable and Disable features in the extension editor as well. Therefore, I couldn't simply make it extend TabOnlyOnFocusActionItem instead of ActionItem. So now I have the same logic repeated in 2 places. Any ideas on how we can improve this?
There was a problem hiding this comment.
How about calling TabOnlyOnFocusActionItem -> ExtensionActionItem that takes tabOnlyOnFocus has input (just like DropDownMenuActionItem) ?
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
How about calling TabOnlyOnFocusActionItem -> ExtensionActionItem that takes tabOnlyOnFocus has input (just like DropDownMenuActionItem) ?
|
LGTM |
|
Thanks @sandy081 I've updated the code as per #59861 (comment) |
This PR attempts to fix the bug #51496
In other lists (Search results, staged/unstaged files in gitview), only the focused list item's actions are shown. Therefore this problem doesnt exist there.
In Extensions viewlet, the actions on all list items are enabled and visible. This PR adds the below as per prior discussions: #59280
ActionItemclass so as to not set tab index on the action item unless it receives focusIExtensionto include a event emitter and listener. The extensions list view would deal with this new class and fire the event on the extension list item that gets/loses focusActionItemin the action bar. It will listen to the focus change event on each extension list item, and update the action item appropriately