Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text search results in API should return all matches on one line in a single result object #59919

Closed
roblourens opened this issue Oct 3, 2018 · 2 comments
Assignees
Labels
api-proposal search Search widget and operation issues
Milestone

Comments

@roblourens
Copy link
Member

roblourens commented Oct 3, 2018

We would change match to matches and range to ranges

/**
 * A preview of the text result.
 */
export interface TextSearchResultPreview {
	/**
	 * The Range within `text` corresponding to the text of the match.
	 */
	matches: Range[];
}

/**
 * A match from a text search
 */
export interface TextSearchLineMatch {
	/**
	 * The range of the match within the document.
	 */
	ranges: Range[];
}
@roblourens roblourens added search Search widget and operation issues api-proposal labels Oct 3, 2018
@roblourens roblourens added this to the October 2018 milestone Oct 3, 2018
@roblourens roblourens self-assigned this Oct 3, 2018
@skprabhanjan
Copy link
Contributor

skprabhanjan commented Oct 4, 2018

@roblourens , is this just changing the names as you suggested, if so can i do that?

@roblourens
Copy link
Member Author

No this will take some discussion and implementation changes, so this one is for me 😁

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api-proposal search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

2 participants