Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel view collapse/expand animation broken #59950

Closed
joaomoreno opened this issue Oct 4, 2018 · 6 comments
Closed

Panel view collapse/expand animation broken #59950

joaomoreno opened this issue Oct 4, 2018 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug splitview-widget Splitview UI system issues verified Verification succeeded
Milestone

Comments

@joaomoreno
Copy link
Member

This commit broke the collapse/expand animation: d4f8481

On my mbp, I don't see the animation any more unless I continuously click the header to collapse and expand many times in a row.

@joaomoreno joaomoreno assigned bpasero and joaomoreno and unassigned bpasero Oct 4, 2018
@joaomoreno
Copy link
Member Author

@bpasero I'll figure out a better fix than d4f8481

@joaomoreno joaomoreno added this to the October 2018 milestone Oct 4, 2018
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug splitview-widget Splitview UI system issues labels Oct 4, 2018
@bpasero
Copy link
Member

bpasero commented Oct 4, 2018

@joaomoreno weird, that must be an issue you only see when using MBP touchpad, it does not reproduce when using a mouse on any OS.

@joaomoreno
Copy link
Member Author

Yeah I figured it was platform/hardware specific...

I'll try to find a way to distinguish between initial creation and other events. 👍

@bpasero
Copy link
Member

bpasero commented Oct 4, 2018

@joaomoreno OK, I tried that initially I think but failed to get that right because some views where coming in just a bit later with a delay.

@joaomoreno
Copy link
Member Author

Hmmm this is really weird... your change actually makes a lot of sense. Investigating...

@joaomoreno
Copy link
Member Author

It was related to the order of listeners to that onDidChange event. We gotta add the listener sync, but we must react to it after the next animation frame. 👍

@mjbvz mjbvz added the verified Verification succeeded label Oct 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug splitview-widget Splitview UI system issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants