Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git commit through Integrated Terminal doesn't work #60294

Closed
pastelmind opened this issue Oct 9, 2018 · 4 comments
Closed

Git commit through Integrated Terminal doesn't work #60294

pastelmind opened this issue Oct 9, 2018 · 4 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@pastelmind
Copy link
Contributor

pastelmind commented Oct 9, 2018

  • VSCode Version: 1.28.0 (user setup)
  • OS Version: Windows 10 Enterprise
  • Using Git for Windows 2.19.1

Steps to Reproduce:

  1. Open a git repository directory in VS code, and stage any changes
  2. Enter git commit in integrated terminal
  3. Enter commit message, save and close COMMIT_EDITMSG
  4. The Integrated Terminal hangs indefinitely with the message "hint: Waiting for your editor to close the file..."
  5. Ctrl+C aborts the git commit process with the following error message:
error: There was a problem with the editor ''C:\Users\Phil\AppData\Local\Programs\Microsoft VS Code\Code.exe' --wait'.
Please supply the message using either -m or -F option.

Does this issue occur when all extensions are disabled?: Yes

@vscodebot
Copy link

vscodebot bot commented Oct 9, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@pastelmind
Copy link
Contributor Author

Changing git config core.editor to 'C:\Users\Phil\AppData\Local\Programs\Microsoft VS Code\Code.exe' --wait -n seems to circumvent the issue--when I attempt to commit or interactively rebase using the integrated terminal, a new instance of VS Code pops up for editing COMMIT_EDITMSG, and closing it completes the commit/rebase. However, I strongly prefer the old behavior, where I could edit COMMIT_EDITMSG inside the current open instance of VS Code.

@vscodebot vscodebot bot removed the new release label Oct 9, 2018
@bpasero
Copy link
Member

bpasero commented Oct 10, 2018

@Tyriar this sounds like #60192

@bpasero bpasero assigned Tyriar and unassigned bpasero Oct 10, 2018
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 10, 2018
@vscodebot
Copy link

vscodebot bot commented Oct 10, 2018

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Oct 10, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

4 participants