Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug: always use scheme when creating uris #60667

Closed
rodrigovaras opened this issue Oct 11, 2018 · 4 comments
Closed

Debug: always use scheme when creating uris #60667

rodrigovaras opened this issue Oct 11, 2018 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@rodrigovaras
Copy link
Contributor

rodrigovaras commented Oct 11, 2018

Steps to Reproduce:

  1. Register a provider debug tracker using something like:
vscode.debug.registerDebugConfigurationProvider('*', this);
public provideDebugAdapterTracker(session: vscode.DebugSession, folder: vscode.WorkspaceFolder | undefined, debugConfig: vscode.DebugConfiguration, token?: vscode.CancellationToken): vscode.IDebugAdapterTracker {
        return new MyTracker();
    }
class  MyTracker implements vscode.IDebugAdapterTracker {
    public toDebugAdapter(message: any): void {

    }
}
  1. Run latest insider
  2. Debug a node app
  3. Press restart

Result: restart never completed

@vscodebot
Copy link

vscodebot bot commented Oct 11, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Oct 11, 2018
@weinand weinand self-assigned this Oct 11, 2018
@weinand weinand added the bug Issue identified by VS Code Team member as probable bug label Oct 11, 2018
@isidorn
Copy link
Contributor

isidorn commented Oct 12, 2018

@rodrigovaras thanks for creating an issue.
I followed your steps and I can not reproduce this with the latest vscode insiders. Note that I do not have any extensions installed.

Let me know if you are doing something differently than me. If yes then please create a GitHub repository with the extension for which you can reproduce this
adaptertracker

@isidorn isidorn added info-needed Issue requires more information from poster and removed bug Issue identified by VS Code Team member as probable bug labels Oct 12, 2018
@rodrigovaras
Copy link
Contributor Author

You are right the latest insiders did fix the issue, but i found another related to IDebugAdapterTracker interface. Same steps as before (register a mock implementation with 'fromDebugAdapter' method.
1 )Have a node app with a line like this 'console.log('foo').
2) Step into
vscode display this:
[UriError]: Scheme is missing: {scheme: "", authority: "", path: "<node_internals>/bootstrap_node.js", query: "", fragment: ""}
image

@isidorn
Copy link
Contributor

isidorn commented Oct 15, 2018

@rodrigovaras thanks, that one is unrelated to the original issue.
The issue here is that we are parsing URI without a scheme here
@weinand we should always use a scheme to respect uri restricitons. I tried changing the code in that location, however it caused some regressions since I think there is another side which does not expect a scheme to be prepanted there

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Oct 15, 2018
@isidorn isidorn added this to the October 2018 milestone Oct 15, 2018
@isidorn isidorn changed the title restart failed when registering a debug adapter tracker Debug: always use scheme when creating uris Oct 15, 2018
@mjbvz mjbvz added the verified Verification succeeded label Nov 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants