Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug console missing when session sending output while not fully initialised #61986

Closed
roblourens opened this issue Oct 28, 2018 · 10 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@roblourens
Copy link
Member

Debug console.log('hi')

  • Get console output
  • Click Clear Console
  • Nothing happens

Sometimes, I start debugging and get no console output at all

@thpeder
Copy link
Member

thpeder commented Nov 13, 2018

I have a similar experience with the insider c72cb12.
After I change the field name and tries to debug again then it doesn't update the messages in the output panel (see the timestamps for each line) and only when I click clear then it shows some of the messages:
insiderdebugoutputclear

@isidorn
Copy link
Contributor

isidorn commented Nov 13, 2018

@roblourens oups this somehow feel through my fingers, sorry about that. Can you still reproduce with the latest insiders? Becuase I can not following your steps
@thpeder that issue I probably introduced yesterday. Can you try to reproduce with running a simple node program
console.log('hello')
Or any reproducable steps would be really helpful for me. Thanks

@isidorn isidorn added info-needed Issue requires more information from poster debug Debug viewlet, configurations, breakpoints, adapter issues labels Nov 13, 2018
@roblourens
Copy link
Member Author

roblourens commented Nov 13, 2018

I don't think I've seen it lately. I can't repro right now.

@isidorn
Copy link
Contributor

isidorn commented Nov 14, 2018

@roblourens got it. So your issue is probably fixed
Let's wait for @thpeder for a potential reproducable sample

@thpeder
Copy link
Member

thpeder commented Nov 14, 2018

@isidorn it might take a bit of time to get a solid repro, but I can give you the trace of what was sent from the language server, would that help?

@isidorn
Copy link
Contributor

isidorn commented Nov 14, 2018

@thpeder I would prefer repro steps, any time in the next 30 days would be great.
We will also see if more users hit this.
Thanks a lot

@thpeder
Copy link
Member

thpeder commented Nov 14, 2018

@isidorn It seems like the logic for when it shows the output messages has changed.
We are sending messages to the debug output panel before replying to the Launch request and if the response to the Launch request is not a success then it doesn't show them.
I have changed the Mock-Debug-Adapter project to reproduce the problem, see here thpeder/vscode-mock-debug.

@isidorn
Copy link
Contributor

isidorn commented Nov 14, 2018

@thpeder thanks for the nice repro steps, the fix should be ini tomorrows vscode insiders.
Please try it out and let us know if this fixes the issue for you.

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Nov 14, 2018
@isidorn isidorn added this to the November 2018 milestone Nov 14, 2018
@isidorn isidorn changed the title Clear Console doesn't work and output is sometimes missing Debug console missing when session sending output while not fully initialised Nov 14, 2018
@StanislawStempin
Copy link

Could you please include this fix in the recovery build 1.29.2? We have many reports from developers using our AL Language extension that they are hitting this issue.

@isidorn
Copy link
Contributor

isidorn commented Nov 20, 2018

@StanislawStempin hi, currently the recvoery build 1.29.2 is not planned.
However if we decide to do this we can include this fix.

My suggestion is to either tell your developers to use vscode insiders
Or to do a recovery release of your extension which fixes this in the following way:
send messages to the output channel while a debug session is not fully initialised, reveal the output channel and hide it appropriatly

Kind regards

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants