files.associations stop accepting wildcard

[FernandoMiguel]

Issue Type: Bug
Until today, using a files.associations with a wildcard, would include all files covered by it.
After updating to todays latest nightly release, that seems to fail.

"files.associations": {
    "Dockerfile-*": "dockerfile",
    "*.yml.*": "yaml",
    "*.tpl": "shellscript",
},

For example, a file called Dockerfile-nginx will be open as Plain Text

VS Code version: Code - Insiders 1.29.0-insider (4626bc0, 2018-10-29T06:11:45.152Z)
OS version: Darwin x64 18.2.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2800)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization: enabled video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled
Load (avg)	2, 2, 2
Memory (System)	16.00GB (0.40GB free)
Process Argv	-psn_0_1524084
Screen Reader	no
VM	0%

Extensions (12)

Extension	Author (truncated)	Version
markdown-toc	Ala	1.5.6
spellright	ban	3.0.6
vscode-icontheme-nomo-dark	be5	1.3.6
gitlens	eam	8.5.6
mdhelper	jos	0.0.11
terraform	mau	1.3.7
prettify-json	moh	0.0.3
vscode-docker	Pet	0.3.1
material-icon-theme	PKi	3.6.0
vscode-icons	rob	7.27.0
vscode-nginx	sha	0.5.0
sort-lines	Tyr	1.7.0

[kernhanda]

@alexandrudima I can still repro this issue with the latest code-insiders release.

Version: 1.29.0-insider
Commit: 97ad72a
Date: 2018-10-31T06:13:36.475Z
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

[alexdima]

@kernhanda The fix is available in today's insiders:

Code - Insiders 1.29.0-insider (d7ac6e8, 2018-11-01T06:20:14.818Z)