Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After npm install gulp extension should find tasks #62129

Merged
merged 3 commits into from
Nov 6, 2018
Merged

After npm install gulp extension should find tasks #62129

merged 3 commits into from
Nov 6, 2018

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Oct 30, 2018

Fixes #61499

@alexr00 alexr00 requested a review from dbaeumer October 30, 2018 09:57
@alexr00 alexr00 added this to the October 2018 milestone Oct 30, 2018
dbaeumer
dbaeumer requested changes Oct 31, 2018
View reviewed changes
Copy link
Member

@dbaeumer dbaeumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment about the pattern.

dbaeumer
dbaeumer approved these changes Oct 31, 2018
View reviewed changes
Copy link
Member

@dbaeumer dbaeumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbaeumer
Copy link
Member

@alexr00 can you please do the same change for jake and grunt. You can directly commit it. No need for a PR :-)

@alexr00 alexr00 modified the milestones: October 2018, November 2018 Oct 31, 2018
@alexr00
Copy link
Member Author

alexr00 commented Oct 31, 2018

@dbaeumer, will do for November!

@dbaeumer
Copy link
Member

dbaeumer commented Nov 1, 2018

Thanks!

@alexr00 alexr00 merged commit c686a15 into master Nov 6, 2018
@alexr00 alexr00 deleted the alexr00/gulpExtensionNode branch November 6, 2018 10:04
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbaeumer dbaeumer dbaeumer approved these changes

Assignees

@dbaeumer dbaeumer

@alexr00 alexr00

Labels
None yet
Projects
None yet
Milestone
November 2018
Development

Successfully merging this pull request may close these issues.

Allow retrying failed task detection
2 participants
@alexr00 @dbaeumer