Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension install should stay when focus lost for bad internet connections #6213

Closed
arliang opened this issue May 9, 2016 · 7 comments
Closed
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality

Comments

@arliang
Copy link

arliang commented May 9, 2016

  • VSCode Version: 1.1.0-insider (1.1.0-insider)
  • OS Version: It may happen on all OS, not clear

Steps to Reproduce:

  1. press cmd(ctrl) - shift - p
  2. enter install ext rainbow
  3. blur from Quick Command Action then it disappears and stops searching.
@isidorn isidorn added the info-needed Issue requires more information from poster label May 9, 2016
@isidorn
Copy link
Contributor

isidorn commented May 9, 2016

@arliang can you please provide a screenshot, or even better a gif?

For me it works fine

screen shot 2016-05-09 at 21 44 43

@arliang
Copy link
Author

arliang commented May 10, 2016

Oh, I'm sorry that I forgot providing the screenshot.
For some WE-CAN'T-SAY-REASONS 😏 , it's hard to connect to the Internet under the protect of GFW 😞 .
cl8n2mgt 9lrtkr3 fdw j

So, this feature is not required outside the GFW 😭

@isidorn
Copy link
Contributor

isidorn commented May 10, 2016

What is GFW? Do you have an internet connection while you are trying the ext install command?
The ext install command will fetch the list of extensions from a server, thus you must have an internet connection while doing this

@arliang
Copy link
Author

arliang commented May 10, 2016

Well, the GFW is an invisible wall between Internet and China Internet (maybe LAN is a better name 😞 ). It makes connections -- from the Mainland to Outland -- slow or fail. That's why there is a cnpm -- a mirror for npm which organized by Taobao.
I should not have talked about this.

At last, it may be better if the Quick Command Action keeps there when losing focus for those people whose internet connections are not good enough. Isn't it?

@isidorn isidorn removed the info-needed Issue requires more information from poster label May 10, 2016
@isidorn
Copy link
Contributor

isidorn commented May 10, 2016

Thanks for more info, assigning to Joao

@isidorn isidorn changed the title It would give up searching extension if blur from Quick Command Action Extension install should stay when focus lost for bad internet connections May 10, 2016
@isidorn isidorn added the feature-request Request for new features or functionality label May 10, 2016
@arliang
Copy link
Author

arliang commented May 10, 2016

Many thanks for the response 😄

@joaomoreno
Copy link
Member

Merging with #637

@joaomoreno joaomoreno added the *duplicate Issue identified as a duplicate of another issue(s) label May 24, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants