Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS quick fix should suggest to use validProperties settings #62160

Closed
isidorn opened this issue Oct 30, 2018 · 3 comments
Closed

CSS quick fix should suggest to use validProperties settings #62160

isidorn opened this issue Oct 30, 2018 · 3 comments
Assignees
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code

Comments

@isidorn
Copy link
Contributor

isidorn commented Oct 30, 2018

Refs: #62049

Have the following css:

nav > a:hover::before {
	isidor: 5;
}

Notice the warning and the quick fixes. I would expect the quick fix to offer to add "isidor" to the "validProperties" setting. That way we would make this setting more discoverable

screenshot 2018-10-30 at 15 55 09

@isidorn isidorn added feature-request Request for new features or functionality css-less-scss Issues and items concerning CSS,Less,SCSS styling labels Oct 30, 2018
@octref octref added this to the October 2018 milestone Oct 30, 2018
@octref
Copy link
Contributor

octref commented Oct 31, 2018

We don't suggest them in IntelliSense either. I think a more sensible approach would be allow #2784 for HTML / CSS. This allows people to add their own definitions to the collections of HTML/CSS tags/properties we source from MDN. We can then update all language features to base off that collection.

That setting is meant as a quick-dirty way to shut up the linter. I don't hope we base all CSS language features from one small setting.

@octref octref added the *out-of-scope Posted issue is not in scope of VS Code label Oct 31, 2018
@vscodebot
Copy link

vscodebot bot commented Oct 31, 2018

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Oct 31, 2018
@isidorn
Copy link
Contributor Author

isidorn commented Oct 31, 2018

Ok makes sense, thanks for the explanation.

@joaomoreno joaomoreno removed this from the October 2018 milestone Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

3 participants