Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree API bug when having highlight [[2, -1]] #62211

Closed
octref opened this issue Oct 30, 2018 · 2 comments
Closed

Tree API bug when having highlight [[2, -1]] #62211

octref opened this issue Oct 30, 2018 · 2 comments
Assignees
@sandy081 @alexr00
Labels
bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues verified Verification succeeded
Milestone
October 2019

Comments

@octref
Copy link
Contributor

octref commented Oct 30, 2018

Testing #62073

Code:

		label: <vscode.TreeItemLabel>{ label: key, highlights: key.length > 1 ? [[2, -1]] : void 0},

Behavior:

image
@octref octref added the tree-widget Tree widget issues label Oct 30, 2018
@octref
Copy link
Contributor Author

octref commented Oct 30, 2018

Same kind of bug when you have [[2, 1]]:
image

@octref octref added the bug Issue identified by VS Code Team member as probable bug label Oct 30, 2018
@sandy081 sandy081 added tree-views Extension tree view issues and removed tree-widget Tree widget issues labels Oct 31, 2018
@sandy081 sandy081 added this to the November 2018 milestone Oct 31, 2018
@sandy081 sandy081 modified the milestones: November 2018, December 2018 Dec 3, 2018
@alexr00 alexr00 self-assigned this Oct 7, 2019
@alexr00
Copy link
Member

alexr00 commented Oct 7, 2019

I think the desired behavior here is to have negative numbers count in from the end of the string (ex. 2,-1 would highlight from 2 up to, but not including, the last character in the string).

@alexr00 alexr00 modified the milestones: Backlog, October 2019 Oct 7, 2019
@alexr00 alexr00 closed this as completed in 491eb9b Oct 7, 2019
@octref octref added the verified Verification succeeded label Oct 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues verified Verification succeeded
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
3 participants
@octref @sandy081 @alexr00