Disabling vscode-icons extension does not reset icons to default

[alexr00]

Not sure if this is a bug for us or a bug for vscode-icons, but it seems like disabled extensions should not permanently modify VS Code state.
Default explorer view:

Explorer view after enabling vscode-icons then disabling it:

[isidorn]

This is an issue that once the file icon theme is disabled we should go back to the previously used file icon theme, not none.
This could be looked into by Martin, however since he is on vacation forwarding to @alexr00 and @sandy081

The issue is probably somewhere around here https://github.com/Microsoft/vscode/blob/f748c0b1636348ca8055d9dcadc4835a92cd0b1a/src/vs/workbench/services/themes/electron-browser/fileIconThemeData.ts#L15

[sandy081]

@alexr00 Feel free to take it up or let me know if we can look into it together.

[aeschli]

The bug is that we don't change back to Seti which is the default icon theme.

We don't have a history of the themes installed, so it's not the previous, but just the default.

[alexr00]

I installed the material icon theme, set the icon theme, then uninstalled that icon theme. After the reload, I had no icons.