Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove error codes from message, source or from other properties #62373

Closed
sandy081 opened this issue Nov 1, 2018 · 3 comments
Closed

Remove error codes from message, source or from other properties #62373

sandy081 opened this issue Nov 1, 2018 · 3 comments
Assignees
@sandy081
Labels
under-discussion Issue is under discussion for relevance, priority, approach
Milestone
November 2018

Comments

@sandy081
Copy link
Member

sandy081 commented Nov 1, 2018

@Microsoft/vscode: Those who are owning built-in extensions and are contributing diagnostics, please remove the error codes from the message or source or other properties, since we now also render error codes.

#49215, #60749
@sandy081 sandy081 added this to the October 2018 milestone Nov 1, 2018
@sandy081 sandy081 self-assigned this Nov 1, 2018
@octref octref added the under-discussion Issue is under discussion for relevance, priority, approach label Nov 1, 2018
@octref
Copy link
Contributor

octref commented Nov 1, 2018

This came in CSS because of #56925.

css.lint.someRule in the beginning does make more sense to me than in the end.

With this I can easily see which linting rule is triggering the error.

@sandy081
Copy link
Member Author

sandy081 commented Nov 2, 2018

@octref source property should only mention the source of the diagnostics like ts, tslint, css. And it should not embed code/rule information. There is code property for that.

About where to show the code, please provide your opinion here -#62370

@joaomoreno joaomoreno modified the milestones: October 2018, November 2018 Nov 2, 2018
@octref
Copy link
Contributor

octref commented Nov 2, 2018

The only one in CSS which I changed back in microsoft/vscode-css-languageservice@4f23ae8. Let's move discussion to #62370.

@octref octref closed this as completed Nov 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Milestone
November 2018
Development

No branches or pull requests
3 participants
@joaomoreno @octref @sandy081