Outline displays wrong hover text for SymbolKind.File

[gjsjohnmurray]

Issue Type: Bug

Implement a DocumentSymbolProvider with a simple provideDocumentSymbols method that returns one SymbolInformation entry for each value of the vscode.SymbolKind enumeration, e.g.

    public async provideDocumentSymbols(document: vscode.TextDocument, token: vscode.CancellationToken): Promise<vscode.SymbolInformation[]> {
		return new Promise<vscode.SymbolInformation[]>((resolve) => {
			let symbols: vscode.SymbolInformation[] = [];
			// This is just so we can see a samples of all icons
			for (i=0; i<26 ; i++) {
				symbols.push(
					new vscode.SymbolInformation(i.toString(), i, '', new vscode.Location(document.uri, new vscode.Position(i,0)))
				);
			}
			/**/

			resolve(symbols);
		});
	}

View the result, and observe how the hover tip for entry 0 (i.e. SymbolKind.File) is "property"

Indeed, the icon used for 0 is the same as for 6, which is the enumeration value for SymbolKind.Property.

Also, the above screenshot shows that SymbolKind.Null uses the same icon as SymbolKind.Boolean, and Module, Namespace, Package and Object all use the same icon. At least in all of these cases the hover tips allow us to distinguish between them.

VS Code version: Code 1.28.2 (7f3ce96, 2018-10-17T00:23:51.859Z)
OS version: Windows_NT x64 10.0.15063

Also occurs in 1.29 Insider.

[vscodebot]

The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines.

Happy Coding!

[jrieken]

Yeah, we reuse some icons for different, but related, types.

[gjsjohnmurray]

But for SymbolKind.File why does the hover tip say 'property' ?

[jrieken]

Yeah, that is weird indeed...

[jrieken]

This is the problem: https://github.com/Microsoft/vscode/blob/f9f38b2bbf5d5049cad387b97b8fa85e98c6d3c4/src/vs/editor/common/modes.ts#L839