Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scss] rename not working for placeholder selectors #62569

Open
QJjs opened this issue Nov 5, 2018 · 0 comments
Open

[scss] rename not working for placeholder selectors #62569

QJjs opened this issue Nov 5, 2018 · 0 comments
Assignees
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality
Milestone

Comments

@QJjs
Copy link

QJjs commented Nov 5, 2018

  • VSCode Version: 1.28.2
  • OS Version: Windows 10

Note: this only happens for .scss file types, as .sass is not supported by VSCode without extensions.

Steps to Reproduce:

  1. Place cursor over sass placeholder selector
  2. Initiate "Rename Symbol" command (through command palette, keyboard shortcuts, etc.)
  3. Attempt to rename

After completion, the text editor will have renamed the variable throughout the document but removed the leading percent sign in the process. Even this can be dealt with by including a leading percent sign while renaming, it should be considered an issue because when the user does not take the effort to work around this quirk, the behavior of the selector is changed.

Example:

%foo {
	...
}

.bar {
	@extends %foo;
}

Attempting to rename foo to foobar results with this:

foobar {
	...
}

.bar {
	@extends foobar;
}

Rather than expected:

%foobar {
	...
}

.bar {
	@extends %foobar;
}

Does this issue occur when all extensions are disabled?: Yes

@vscodebot vscodebot bot added the editor-contrib Editor collection of extras label Nov 5, 2018
@kieferrm kieferrm removed the editor-contrib Editor collection of extras label Nov 5, 2018
@octref octref added the css-less-scss Issues and items concerning CSS,Less,SCSS styling label Nov 5, 2018
@octref octref added this to the Backlog milestone Nov 5, 2018
@octref octref added the bug Issue identified by VS Code Team member as probable bug label Nov 5, 2018
@octref octref added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Oct 21, 2019
@octref octref assigned aeschli and unassigned octref May 1, 2020
@aeschli aeschli changed the title Rename symbol working incorrectly for Sass placeholder selectors [scss] rename not working for placeholder selectors May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants