Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix strict null errors in 'vs/base/node/config.ts' #62821

Closed
mjbvz opened this issue Nov 9, 2018 · 0 comments
Closed

Fix strict null errors in 'vs/base/node/config.ts' #62821

mjbvz opened this issue Nov 9, 2018 · 0 comments
Assignees
@sandy081
Labels
engineering VS Code - Build / issue tracking / etc.
Milestone
November 2018

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Nov 9, 2018

Part of #60565

Tracks updating vs/base/node/config.ts to have strict null checking. I tried converting this file but was not sure when undefined was expected or not

Steps

  1. Add ./s/base/node/config.ts to the files section of src/tsconfig.strictNullChecks.json
  2. Run yarn strict-null-check -- --watch
  3. Fix strict null check compiler errors url
  4. Verify normal build still works
@mjbvz mjbvz added the engineering VS Code - Build / issue tracking / etc. label Nov 9, 2018
@sandy081 sandy081 added this to the November 2018 milestone Nov 12, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Milestone
November 2018
Development

No branches or pull requests
2 participants
@sandy081 @mjbvz