Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smarter logic for $onVirtualDocumentChange #62849

Closed
jrieken opened this issue Nov 9, 2018 · 1 comment
Closed

Smarter logic for $onVirtualDocumentChange #62849

jrieken opened this issue Nov 9, 2018 · 1 comment
Assignees
@jrieken
Labels
extensions Issues concerning extensions perf
Milestone
November 2018

Comments

@jrieken
Copy link
Member

jrieken commented Nov 9, 2018

Originally posted by @jrieken in #62802 (comment)
@jrieken jrieken changed the title I have created a PR that reverts https://github.com/Microsoft/vscode/commit/bab31465aeefbe9f4c31f5895b772975478ee2f8. For master (1.30-insiders) I will work on a different fix. Smarter logic for $onVirtualDocumentChange Nov 9, 2018
@jrieken
Copy link
Member Author

jrieken commented Nov 9, 2018

For 1.29 we reverted back to use setModel but we can do better for 1.30...

@jrieken jrieken self-assigned this Nov 9, 2018
@jrieken jrieken added this to the November 2018 milestone Nov 9, 2018
@jrieken jrieken added extensions Issues concerning extensions perf labels Nov 9, 2018
@jrieken jrieken closed this as completed in 1ce7980 Nov 9, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
extensions Issues concerning extensions perf
Projects
None yet
Milestone
November 2018
Development

No branches or pull requests
1 participant
@jrieken