Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search.useIgnoreFiles ignored when working with new search #63128

Closed
Kamadake opened this issue Nov 14, 2018 · 2 comments
Closed

search.useIgnoreFiles ignored when working with new search #63128

Kamadake opened this issue Nov 14, 2018 · 2 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Milestone
November 2018

Comments

@Kamadake
Copy link

  • VSCode Version: 1.29.0
  • OS Version: Mac OS 10.14

Steps to Reproduce:

  1. have "search.useIgnoreFiles: false" in your workspace settings
  2. add folder to .gitignore
  3. search for content inside that folder with "Use Exclude Settings" enabled in search window
  4. still can't find content inside that folder even though useIgnoreFiles is disabled
  5. enable "search.useLegacySearch" in the workspace settings and it starts working as it should
@roblourens roblourens self-assigned this Nov 14, 2018
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues labels Nov 14, 2018
@roblourens roblourens mentioned this issue Nov 16, 2018
Closed
@YisraelV
Copy link
Contributor

@roblourens this code ignores the value in settings if the value in options is set. Hope that's any help

disregardIgnoreFiles: typeof options.disregardIgnoreFiles === 'boolean' ? options.disregardIgnoreFiles : !folderConfig.search.useIgnoreFiles

@vscodebot vscodebot bot removed the new release label Nov 20, 2018
@Kamadake
Copy link
Author

Awesome ❤️

@roblourens roblourens added this to the November 2018 milestone Nov 21, 2018
@Tyriar Tyriar added the verified Verification succeeded label Dec 5, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Milestone
November 2018
Development

No branches or pull requests
4 participants
@roblourens @Tyriar @Kamadake @YisraelV