Show Reload full text as sub text #63187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
commented
Nov 15, 2018
| @@ -437,6 +402,67 @@ export class ExtensionEditor extends BaseEditor { | |||
| return super.setInput(input, options, token); | |||
| } | |||
|
|
|||
| private setSubText(extension: IExtension, reloadAction: ReloadAction) { | |||
| if (reloadAction.enabled) { | |||
There was a problem hiding this comment.
@sandy081 This if never returns true. This is because the update of the "enabled" status on the ReloadAction is not a synchronous operation.
How do you suggest we tackle this? Other than adding a listener for when the ReloadAction changes its enabled status.
There was a problem hiding this comment.
In such cases we listen to onDidChange event from the Action. See below
sandy081
requested changes
Nov 16, 2018
| @@ -437,6 +402,67 @@ export class ExtensionEditor extends BaseEditor { | |||
| return super.setInput(input, options, token); | |||
| } | |||
|
|
|||
| private setSubText(extension: IExtension, reloadAction: ReloadAction) { | |||
| if (reloadAction.enabled) { | |||
There was a problem hiding this comment.
In such cases we listen to onDidChange event from the Action. See below
ramya-rao-a
force-pushed
the
ramyar/reload-subtext
branch
from
e7bc117
to
fe83544
Compare
|
The |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to implement #60053 (comment)
Please reload Visual Studio Code to complete the .....ing of this extension.This currently wont work due to https://github.com/Microsoft/vscode/pull/63187/files#r233713325