Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiments shld provide local text for commands too #63261

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

ramya-rao-a
Copy link
Contributor

@ramya-rao-a ramya-rao-a commented Nov 16, 2018

53ec5ac#diff-90725d5e77bad319c8378b0eb8f0c17e allowed localized text for the prompts

This PR does the same for the text in the commands that show as buttons in the notifications

@ramya-rao-a ramya-rao-a self-assigned this Nov 16, 2018
@ramya-rao-a
Copy link
Contributor Author

@roblourens ping

Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reminder, looks good to me.

@ramya-rao-a ramya-rao-a merged commit 9d4f718 into master Dec 3, 2018
@ramya-rao-a ramya-rao-a deleted the ramyar/experiment-localtext branch December 3, 2018 17:20
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants