Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./ doesn't work in "files to exclude" #63303

Closed
borekb opened this issue Nov 16, 2018 · 4 comments
Closed

./ doesn't work in "files to exclude" #63303

borekb opened this issue Nov 16, 2018 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded

Comments

@borekb
Copy link

borekb commented Nov 16, 2018

  • VSCode Version: 1.29.1
  • OS Version: macOS Mojave

Previously, including ./somedir and excluding ./somedir/subdirectory would find all matches everywhere in somedir except subdirectory. In 1.29, I also get results from the subdirectory.

There have been quite a few search-related changes in 1.29, is this one of them? I have to say that I found the previous behavior more intuitive.

(I'm able to replicate in 1.30 insiders.)

@borekb
Copy link
Author

borekb commented Nov 20, 2018

UPDATE: moved to a separate issue: #63522


Cloud this be related? I'm pretty sure PHP files used to be filtered out with this expression (actually, I used to use just !*.php; this new !**/*.php is my attempt to make it work but it doesn't either).

screenshot 2018-11-20 at 14 24 34

@roblourens
Copy link
Member

I don't think that's related, can you file a separate issue for @sandy081? Thanks

@borekb
Copy link
Author

borekb commented Nov 20, 2018

Done: #63522.

@roblourens
Copy link
Member

I think the bug is just that ./ syntax doesn't work in files to exclude

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues labels Nov 26, 2018
@roblourens roblourens added this to the November 2018 milestone Nov 26, 2018
@roblourens roblourens changed the title Search: 'Files to exclude' no longer beats 'Files to include' ./ doesn't work in "files to exclude" Nov 26, 2018
@mjbvz mjbvz added the verified Verification succeeded label Jan 31, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants