Can't close tab with middle mouse click when mouse is over the close button

[xchrdw]

• VSCode Version: 1.29.0
• OS Version: Linux

Steps to Reproduce:

1. Try to close multiple tabs with middle mouse click
2. Due to varying tab length, the mouse will at some point be over the close button of a tab
3. Tabs can't be closed when the mouse is over the close button ('x')

Does this issue occur when all extensions are disabled?: Yes

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Middle Click to only Close Current Tab (#62229)
• Always create new file tab when click file with mouse middle button (#39534)
• Allow to close multiple tabs without moving the mouse after closing one (#40290)
• Middle mouse button doesn't scroll editor window (#40985)
• middle click to close active non tab window when click on name area at top? (#63185)

[bpasero]

If someone wants to fix this, be my guest.

[JohanssonDaniel]

Hi @bpasero can I take a look at this?

[bpasero]

@JohanssonDaniel sure go ahead, my guess would be somewhere in tabsTitleControl.ts

[JohanssonDaniel]

@bpasero Okay, I will start to look there

[bpasero]

Looks like this is caused by the check for e.button === 1 /* Middle Button*/ && !this.originatesFromTabActionBar(e) in tabsTitleControl.ts which was added for 35a12c9 but I cannot reproduce that issue anymore (possibly due to the e.stopPropagation() right after which we did not have back in the days).

[bpasero]

Unfortunately I can still reproduce the issue on Windows when I remove that check so the solution has to solve both issues...

[JohanssonDaniel]

Hi @bpasero! I have tried to reproduce the issue you mentioned by removing the !this.originatesFromTabActionBar(e) check without success on both of my windows machines with two different mouses. Without the check, I am able to close a single tab by clicking with the middle mouse button on the x icon (and also anywhere else on the tab) without closing the tab to the right.

With check

Without check

Since I am not able to reproduce it, it might be a good idea if someone else can work on it instead. It might also be a good idea to check with other mouses since I know from my own experience that the middle mouse button might become faulty and randomly perform double clicks. I did a quick google search and it seems to be a common enough problem that it might be worth looking into 👍

[bpasero]

@JohanssonDaniel did you try on Windows?

[JohanssonDaniel]

Yes, I tried it on two computers running windows.

[xqin]

I have same issue on Mac/Windows VSCode.

can not close file when i use middle key click close button on the tab.

Mac:

Version 1.29.1 (1.29.1)

bc24f98b5f70467bc689abf41cc5550ca637088e

2018-11-15T18:59:37.244Z

Windows:

Version: 1.29.1 (user setup)
Commit: bc24f98b5f70467bc689abf41cc5550ca637088e
Date: 2018-11-15T19:13:36.375Z
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

[bpasero]

I think the fix is actually fine, what I saw seems to be a feature of my mouse where when I press the middle mouse button hard enough it will actually fire MOUSE_UP events periodically. We have to be on the watch out for users reporting a regression though.