Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search input box is 2 row high #63685

Closed
alexdima opened this issue Nov 23, 2018 · 7 comments
Closed

Search input box is 2 row high #63685

alexdima opened this issue Nov 23, 2018 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Milestone

Comments

@alexdima
Copy link
Member

alexdima commented Nov 23, 2018

Issue Type: Bug

The Search input box is 2 rows high. I have been using search, no particular steps...

image

VS Code version: Code - Insiders 1.30.0-insider (8b86554, 2018-11-23T06:17:27.340Z)
OS version: Windows_NT ia32 10.0.17134

@usernamehw
Copy link
Contributor

usernamehw commented Nov 23, 2018

Isn't it new feature: after pressing Shift+Enter for easier multi-line searching?

@alexdima
Copy link
Member Author

But shouldn't it shrink back to 1 row when the text does not contain a \n ?

@roblourens
Copy link
Member

That's weird. I don't see that happening. It's always like that, or did it just show up at some point?

@alexdima
Copy link
Member Author

I cannot reproduce when I try. I will keep an eye out and if I see it again I'll update the issue.

@alexdima alexdima added the info-needed Issue requires more information from poster label Nov 23, 2018
@roblourens
Copy link
Member

The sizing is done just by measuring the text in a .mirror div next to the textarea. Would help if you can poke around there in the DOM to see if anything looks obviously out of place.

@alexdima
Copy link
Member Author

And now I have steps :) :

  • type a long string to get two rows
  • resize the viewlet to make space on a single row for the long string
  • the input does not go back to 1 row

63685

@alexdima alexdima removed the info-needed Issue requires more information from poster label Nov 27, 2018
@roblourens
Copy link
Member

Oh, good catch

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues labels Nov 28, 2018
@roblourens roblourens added this to the November 2018 milestone Nov 28, 2018
@mjbvz mjbvz added the verified Verification succeeded label Dec 6, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants