Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not display error in js/ts references code lenses when document changes #63884

Closed
mjbvz opened this issue Nov 28, 2018 · 0 comments
Closed

Do not display error in js/ts references code lenses when document changes #63884

mjbvz opened this issue Nov 28, 2018 · 0 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug code-lens javascript JavaScript support issues typescript Typescript support issues verified Verification succeeded
Milestone
November 2018

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Nov 28, 2018

Steps to Reproduce:

  1. Enable the typescript references code lens
  2. Open a larger file in VS Code such as src/vs/editor/common/modes.ts
  3. Wait for the first reference code lens to come in
  4. As soon as this happens—and before the other visible code lens locations have been resolved—make file edit

Bug
Code lenses that have not been resolved show as could not resolve references. This is because they are canceled when the document changes. We should not treat cancellation as an error as the requests are immediately re-queued
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues javascript JavaScript support issues code-lens labels Nov 28, 2018
@mjbvz mjbvz added this to the November 2018 milestone Nov 28, 2018
@mjbvz mjbvz self-assigned this Nov 28, 2018
@mjbvz mjbvz closed this as completed in 9d22514 Nov 28, 2018
@sandy081 sandy081 added the verified Verification succeeded label Dec 5, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug code-lens javascript JavaScript support issues typescript Typescript support issues verified Verification succeeded
Projects
None yet
Milestone
November 2018
Development

No branches or pull requests
2 participants
@sandy081 @mjbvz