-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input variables in tasks #63910
Input variables in tasks #63910
Conversation
@isidorn, could you take a look at the configurationResolver* files? I made some significant changes to them and I want to make sure you're ok with them. |
src/vs/workbench/services/configurationResolver/common/configurationResolver.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/services/configurationResolver/common/configurationResolver.ts
Outdated
Show resolved
Hide resolved
@alexr00 I took a look at the changes you made to the
Apart from that I would add a bit more comments once you find the time. I know it was like that before, but we could improve this. @weinand might also want to take a look at the changes. |
@alexr00 Please make sure that variables are resolved correctly in all builds |
Fixes #4758