Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log levels passed to extension are off by one #64273

Closed
kieferrm opened this issue Dec 4, 2018 · 2 comments
Closed

Log levels passed to extension are off by one #64273

kieferrm opened this issue Dec 4, 2018 · 2 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
November 2018

Comments

@kieferrm
Copy link
Member

kieferrm commented Dec 4, 2018

Issue Type: Bug

vscode.env.logLevel is supposed to be 1-based (as defined by vscode.LogLevel by reaches the extensions as 0-based value.

VS Code version: Code - Insiders 1.30.0-insider (9e62a05, 2018-12-03T06:12:08.874Z)
OS version: Darwin x64 18.0.0
@vscodebot vscodebot bot added the insiders label Dec 4, 2018
@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Dec 4, 2018
@sandy081 sandy081 added this to the November 2018 milestone Dec 4, 2018
@roblourens roblourens removed their assignment Dec 5, 2018
@sandy081 sandy081 assigned roblourens and unassigned sandy081 Dec 5, 2018
@sandy081
Copy link
Member

sandy081 commented Dec 5, 2018

@roblourens I think you have introduced the LogLevel in proposed API, so moving it back to you.

@roblourens
Copy link
Member

Ok it's been so long I honestly couldn't remember!

@jrieken jrieken added the verified Verification succeeded label Dec 6, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
November 2018
Development

No branches or pull requests
4 participants
@roblourens @jrieken @kieferrm @sandy081