Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

input variables: suggest to use "name" or "id" instead of "label" #64356

Closed
weinand opened this issue Dec 4, 2018 · 0 comments
Closed

input variables: suggest to use "name" or "id" instead of "label" #64356

weinand opened this issue Dec 4, 2018 · 0 comments
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Milestone
November 2018

Comments

@weinand
Copy link
Contributor

weinand commented Dec 4, 2018

testing #64214:

A variable reference is tied to its definition via the "label" attribute.
In addition the "label" does not show up in the UI anywhere.

This makes the use of "label" somewhat confusing because it suggests a UI concept.

I suggest to either use "id" or a less-technical "name" attribute instead.
@alexr00 alexr00 added this to the November 2018 milestone Dec 5, 2018
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug tasks Task system issues labels Dec 5, 2018
@alexr00 alexr00 closed this as completed in e17f303 Dec 5, 2018
@weinand weinand added the verified Verification succeeded label Dec 6, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Projects
None yet
Milestone
November 2018
Development

No branches or pull requests
2 participants
@weinand @alexr00