Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not seeing any user facing alert for stalled extension #64388

Closed
mjbvz opened this issue Dec 4, 2018 · 2 comments
Closed

Not seeing any user facing alert for stalled extension #64388

mjbvz opened this issue Dec 4, 2018 · 2 comments
Assignees
Labels
*not-reproducible Issue cannot be reproduced by VS Code Team member as described
Milestone

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Dec 4, 2018

Issue Type: Bug

Testing #64222

  1. For an extension:
import * as vscode from 'vscode';

export function activate(context: vscode.ExtensionContext) {
    vscode.commands.registerCommand('myExtension.sayHello', async () => {
        const start = Date.now();
        while (true) {
            const now = Date.now();
            if (Math.abs(start - now) >= 30000) {
                break;
            }
        }
        console.log('done');
    });
}
  1. Install the extension (test-ext-0.0.2.vsix.zip) and run the say hello command.

Bug
During the stall, I see alerts printed in the dev console but not user facing warnings. No hidden notifications or alerts

VS Code version: Code - Insiders 1.30.0-insider (fa87e67, 2018-12-04T09:26:33.257Z)
OS version: Darwin x64 18.2.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 4, 4, 4
Memory (System) 16.00GB (0.21GB free)
Process Argv
Screen Reader no
VM 25%
@vscodebot vscodebot bot added the insiders label Dec 4, 2018
@jrieken jrieken self-assigned this Dec 5, 2018
@jrieken jrieken added this to the November 2018 milestone Dec 5, 2018
@jrieken
Copy link
Member

jrieken commented Dec 5, 2018

During the stall, I see alerts printed in the dev console but not user facing warnings. No hidden notifications or alerts

I does that because your extension doesn't have a repo-url in its package.json. We figured not to blame those extensions because a user cannot really follow up (except for removing that extension)

@mjbvz
Copy link
Contributor Author

mjbvz commented Dec 5, 2018

Yes, that was the issue. Everything looks good once I added that

@mjbvz mjbvz closed this as completed Dec 5, 2018
@mjbvz mjbvz added the *not-reproducible Issue cannot be reproduced by VS Code Team member as described label Dec 5, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*not-reproducible Issue cannot be reproduced by VS Code Team member as described
Projects
None yet
Development

No branches or pull requests

2 participants