Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing variable from object to primitive value, expand arrow isn't removed #64394

Closed
roblourens opened this issue Dec 5, 2018 · 3 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues tree-widget Tree widget issues verified Verification succeeded
Milestone

Comments

@roblourens
Copy link
Member

Testing #64003

  • Debug this code, set a BP on the console.log:
setInterval(() => {
    let x = { a: 1 };
    console.log(x);
}, 1000);
  • Expand the x object
  • Edit x to a primitive value like 123
  • x still has the expand arrow in the variables pane

image

  • The expand arrow goes away correctly in 1.29
@roblourens
Copy link
Member Author

I also see this for watch entries

@isidorn
Copy link
Contributor

isidorn commented Dec 5, 2018

@joaomoreno this looks like an issue with the tree.
If the element with the same ID after a refesh no longer has children the expando is left behind.
Assigning to you also if you have time to investigate.

@isidorn isidorn added this to the November 2018 milestone Dec 5, 2018
@joaomoreno
Copy link
Member

Pretty sure it's the same as #64074, but let's see.

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues tree-widget Tree widget issues labels Dec 5, 2018
@weinand weinand added the verified Verification succeeded label Dec 6, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues tree-widget Tree widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants