Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing ... suggestion showing in ts files on arrow functions #64395

Closed
mjbvz opened this issue Dec 5, 2018 · 1 comment
Closed

Confusing ... suggestion showing in ts files on arrow functions #64395

mjbvz opened this issue Dec 5, 2018 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues verified Verification succeeded
Milestone

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Dec 5, 2018

Issue Type: Bug

repo

  1. Using TS 3.2
  2. Open a ts file:
const a = (x) => x; 

Bug
Notice the ... under x. When you move the cursor over the ..., we offer the convert to braces / remove braces refactoring

This behavior is really confusing. Accepting these refactors will not get rid of the ..., which is actually an infer type suggestion

VS Code version: code-oss-dev 1.30.0 (Commit unknown, Date unknown)
OS version: Darwin x64 18.2.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 5, 5, 5
Memory (System) 16.00GB (0.15GB free)
Process Argv .
Screen Reader no
VM 25%
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues labels Dec 5, 2018
@mjbvz mjbvz added this to the November 2018 milestone Dec 5, 2018
@mjbvz mjbvz self-assigned this Dec 5, 2018
@mjbvz
Copy link
Contributor Author

mjbvz commented Dec 5, 2018

Root cause microsoft/TypeScript#28702 but I'm just going to disable these suggestions entirely on broken TS versions

@mjbvz mjbvz closed this as completed in 5010af1 Dec 5, 2018
@sbatten sbatten added the verified Verification succeeded label Dec 7, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants