Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress display of end-of-file newline as blank line #64667

Merged
merged 3 commits into from
Feb 18, 2019

Conversation

pedromsfernandes
Copy link
Contributor

Fixes #1027.
We read the thread and the consensus seemed to be that there should be a setting that controls the display of the numbered blank line at the end of files. So that's what we did. We're not sure if we used the most correct naming, but after a couple of tests it does seem to work as intended. Here are some screenshots:

Added setting
eof-nl-setting

No blank like
eof-no-nl

Setting on
eof-nl-on

Setting off
eof-nl-off

@msftclas
Copy link

msftclas commented Dec 8, 2018

CLA assistant check
All CLA requirements met.

@alexdima alexdima merged commit 3d662dd into microsoft:master Feb 18, 2019
@alexdima alexdima added this to the February 2019 milestone Feb 18, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppress display of end-of-file newline as blank line
5 participants