Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree - have useAltAsMultipleSelectionModifier #64889

Closed
jrieken opened this issue Dec 12, 2018 · 5 comments
Closed

tree - have useAltAsMultipleSelectionModifier #64889

jrieken opened this issue Dec 12, 2018 · 5 comments
Assignees
Labels
tree-widget Tree widget issues

Comments

@jrieken
Copy link
Member

jrieken commented Dec 12, 2018

re #64727

Today workbench tree have useAltAsMultipleSelectionModifier which is used by the explorer, open editors view, and outline and we need some sort of equivalent for the new tree world

@jrieken
Copy link
Member Author

jrieken commented Dec 12, 2018

cc @isidorn

@joaomoreno
Copy link
Member

From the code, this should work. I've tested the Watch Expressions tree and switching the setting does alter its behavior. Doesn't work for you? You have to pass in multipleSelectionSupport: true to the tree options, maybe that's the difference?

@jrieken
Copy link
Member Author

jrieken commented Dec 12, 2018

switching the setting does alter its behavior.

You that it reflects that in the corresponding event?

@joaomoreno
Copy link
Member

Oh I wasn't aware these workbench lists and trees re-expose that stuff... pushing exposition of that boolean.

@joaomoreno joaomoreno added this to the December 2018 milestone Dec 12, 2018
@joaomoreno joaomoreno added feature-request Request for new features or functionality tree-widget Tree widget issues labels Dec 12, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 26, 2019
@joaomoreno joaomoreno removed the feature-request Request for new features or functionality label Jan 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tree-widget Tree widget issues
Projects
None yet
Development

No branches or pull requests

2 participants