Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workbench.editor.closeEmptyGroups not showing up when searching "pane" #65795

Open
irvnriir opened this issue Dec 29, 2018 · 4 comments
Open
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member settings-editor VS Code settings editor issues settings-search Settings editor remote search provider issues
Milestone

Comments

@irvnriir
Copy link

irvnriir commented Dec 29, 2018

i usually set up 2 equal width,,horizontally split-ed panes and 1 full width under them .

currently i found no way to create editor-width pane at bottom, if you have at least 2 column ones (like was possible in VS) .
add to this a fact of that the full width panel auto closes with it's last tab, and it becomes an issue (so if the last tab at bottom are accidentally closed, its needed to close 1 of the upper panes, split to bottom and then split to side again) . (Close Empty Groups setting, it misses "Pane" as a {search tag}/synonym)

this may look minor, but the splitting functionality just basically not complete, and ability to control tabs auto-closing behavior are missed.

@yume-chan
Copy link
Contributor

yume-chan commented Dec 29, 2018

For the later part, you can set workbench.editor.closeEmptyGroups: false so closing last tab in a group will result in an empty group.

@irvnriir
Copy link
Author

irvnriir commented Dec 29, 2018

@yume-chan, damn, i missed the setting, sorry and thanks, it would be good to add "pane" word to the setting's description (for search)

@octref
Copy link
Contributor

octref commented Dec 30, 2018

@roblourens Is it possible to add "pane" as a synonym for "editor group"?

Otherwise it seems @Ilias48rus's problem is gone, so I'm closing the issue.

@octref octref closed this as completed Dec 30, 2018
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues labels Dec 30, 2018
@roblourens
Copy link
Member

Yes

@roblourens roblourens reopened this Dec 30, 2018
@roblourens roblourens added this to the Backlog milestone Oct 27, 2019
@rzhao271 rzhao271 added the confirmed Issue has been confirmed by VS Code Team member label Nov 6, 2020
@rzhao271 rzhao271 changed the title Panes splitting, auto closing workbench.editor.closeEmptyGroups not showing up when searching "pane" Nov 6, 2020
@rzhao271 rzhao271 assigned rzhao271 and unassigned roblourens Oct 15, 2021
@rzhao271 rzhao271 added the settings-search Settings editor remote search provider issues label Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member settings-editor VS Code settings editor issues settings-search Settings editor remote search provider issues
Projects
None yet
Development

No branches or pull requests

5 participants