Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextEdit.setEndOfLine applies an edit and invalidates redo stack even when no change is made #66214

Closed
Tyriar opened this issue Jan 8, 2019 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 8, 2019

Repros in 1.30.2 and 1.31.0-insiders, not 1.29.1

Repro:

  1. Install Editor Config extension

  2. Add .editorconfig file to root with this contents:

    root = true
    
    [*]
    end_of_line = lf
    
  3. Open some file

  4. Delete 2 lines

  5. Save

  6. Undo three times (notice that you have to undo 3 times to undo the 2 edits, this is because TextEdit.setEndOfLine caused an extra edit)

  7. Save

  8. Try redo, this doesn't work because TextEdit.setEndOfLine caused an edit

Related discussion:

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Jan 8, 2019
@jrieken
Copy link
Member

jrieken commented Jan 8, 2019

@alexdima
Copy link
Member

alexdima commented Jan 9, 2019

This got introduced via 0ac0c45#diff-4b2e90f9fb35dd653ba8b975c7a625f8R450

@alexdima alexdima added this to the December/January 2019 milestone Jan 9, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Jan 9, 2019

@alexandrudima thanks for the quick fix!

@Tyriar Tyriar added the verified Verification succeeded label Jan 31, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants