Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove razor support for HTML #66242

Closed
octref opened this issue Jan 9, 2019 · 4 comments
Closed

Remove razor support for HTML #66242

octref opened this issue Jan 9, 2019 · 4 comments
Assignees
Labels
debt Code quality issues feature-request Request for new features or functionality html HTML support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@octref
Copy link
Contributor

octref commented Jan 9, 2019

https://github.com/aspnet/Razor.VSCode handles Razor files much better. We should remove its support from our built-in HTML language features.

@aeschli What do you think?

@octref octref added html HTML support issues debt Code quality issues labels Jan 9, 2019
@octref octref added this to the Backlog milestone Jan 9, 2019
@aeschli
Copy link
Contributor

aeschli commented Jan 9, 2019

I agree! @egamma Ok for you?

But we should add a extension recommendation for to help razor users to move to the new extension.

https://github.com/Microsoft/vscode-distro/blob/master/quality/stable/product.json

@aeschli aeschli modified the milestones: Backlog, December/January 2019 Jan 9, 2019
@aeschli aeschli assigned octref and unassigned aeschli Feb 22, 2019
@octref octref added the feature-request Request for new features or functionality label Feb 24, 2019
@octref
Copy link
Contributor Author

octref commented Feb 25, 2019

Verification: Verify that cshtml files now prompt C# extension as recommendation

@octref octref closed this as completed in 393b48d Feb 25, 2019
@octref octref added the verification-needed Verification of issue is requested label Feb 25, 2019
@alexr00 alexr00 reopened this Feb 26, 2019
@alexr00 alexr00 added verification-found Issue verification failed and removed verification-found Issue verification failed labels Feb 26, 2019
@alexr00 alexr00 closed this as completed Feb 26, 2019
@alexr00
Copy link
Member

alexr00 commented Feb 26, 2019

Should there be a notification, or just C# listed in the Recommended Extensions view? I don't see a prompt and the language in the bottom right corner is still razor.

@octref
Copy link
Contributor Author

octref commented Feb 26, 2019

I see, I should have made that a strong recommendation...

@octref octref reopened this Feb 26, 2019
@octref octref closed this as completed in 0db622d Feb 26, 2019
@roblourens roblourens added the verified Verification succeeded label Feb 26, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues feature-request Request for new features or functionality html HTML support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants