Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow kill terminal from the terminal context menu #66535

Merged
merged 4 commits into from Jan 24, 2019
Merged

Allow kill terminal from the terminal context menu #66535

merged 4 commits into from Jan 24, 2019

Conversation

asaf050
Copy link

@asaf050 asaf050 commented Jan 15, 2019

Background:

Once split terminal panel to multiple terminals, is more effective to allow user to kill a single terminal from the context menu.

In this PR:

  • Add another existing action to the terminal context menu.

@asaf050 asaf050 changed the title Allow kill terminal from the terminal's context menu Allow kill terminal from the terminal context menu Jan 15, 2019
Tyriar
Tyriar requested changes Jan 16, 2019
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually thought this was already there 😅

Let's add a separator in between clear and kill, then this looks good to me 👍

@Tyriar Tyriar added this to the December/January 2019 milestone Jan 16, 2019
@asaf050
Copy link
Author

asaf050 commented Jan 19, 2019

@Tyriar Hey :)
I've add the separator , you can have a look 👍

Tyriar
Tyriar approved these changes Jan 24, 2019
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @asaf050!

@Tyriar Tyriar mentioned this pull request Jan 24, 2019
Closed
@Tyriar Tyriar merged commit adf0b19 into microsoft:master Jan 24, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
December/January 2019
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asaf050 @Tyriar