Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree gets empty after zooming #66972

Closed
isidorn opened this issue Jan 23, 2019 · 6 comments
Closed

Tree gets empty after zooming #66972

isidorn opened this issue Jan 23, 2019 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug list-widget List widget issues verified Verification succeeded

Comments

@isidorn
Copy link
Contributor

isidorn commented Jan 23, 2019

Steps: sorry but no real steps. I get into this situation with the combination of
zooming in, reseting zoom, showing / hiding sidebar
and having a file open which is not in the explorer (so it does not get revelaed)

Assigning to december since it is rather bad (reload only helps)

screenshot 2019-01-23 at 10 49 04

Here's the full HTML of the tree I was able to copy from chrome

<div class="monaco-list mouse-support list_id_1 element-focused selection-single" role="tree" tabindex="0" aria-label="Files Explorer. Use the navigation keys to navigate." data-keybinding-context="3" aria-activedescendant="list_id_1_49"><div class="monaco-scrollable-element  mac" role="presentation" style="position: relative; overflow: hidden;"><div class="monaco-list-rows" style="overflow: hidden; top: -889px; height: 1342px; transform: translate3d(0px, 0px, 0px);"><div class="monaco-list-row" data-index="0" data-last-element="false" aria-setsize="61" aria-posinset="1" role="treeitem" id="list_id_1_0" aria-label=".github" aria-level="1" draggable="true" style="top: 0px; height: 22px; line-height: 22px;"><div class="monaco-tl-row"><div class="monaco-tl-twistie collapsible collapsed" style="margin-left: 8px;"></div><div class="monaco-tl-contents"><div class="monaco-icon-label folder-icon .github-name-folder-icon explorer-item" title="~/Development/vscode/.github" style="display: flex;"><div class="monaco-icon-label-description-container"><a class="label-name"><span class="monaco-highlighted-label" title="~/Development/vscode/.github"><span>.github</span></span></a></div></div></div></div></div><div class="monaco-list-row selected" data-index="1" data-last-element="false" aria-setsize="61" aria-posinset="2" role="treeitem" id="list_id_1_1" aria-label=".vscode" aria-level="1" draggable="true" style="top: 22px; height: 22px; line-height: 22px;"><div class="monaco-tl-row"><div class="monaco-tl-twistie collapsible" style="margin-left: 8px;"></div><div class="monaco-tl-contents"><div class="monaco-icon-label folder-icon .vscode-name-folder-icon explorer-item" title="~/Development/vscode/.vscode" style="display: flex;"><div class="monaco-icon-label-description-container"><a class="label-name"><span class="monaco-highlighted-label" title="~/Development/vscode/.vscode"><span>.vscode</span></span></a></div></div></div></div></div><div class="monaco-list-row" data-index="2" data-last-element="false" aria-setsize="61" aria-posinset="3" role="treeitem" id="list_id_1_2" aria-label="cglicenses.schema.json" aria-level="2" draggable="true" style="top: 44px; height: 22px; line-height: 22px;"><div class="monaco-tl-row"><div class="monaco-tl-twistie" style="margin-left: 16px;"></div><div class="monaco-tl-contents"><div class="monaco-icon-label file-icon cglicenses.schema.json-name-file-icon schema.json-ext-file-icon json-ext-file-icon ext-file-icon json-lang-file-icon explorer-item" title="~/Development/vscode/.vscode/cglicenses.schema.json" style="display: flex;"><div class="monaco-icon-label-description-container"><a class="label-name"><span class="monaco-highlighted-label" title="~/Development/vscode/.vscode/cglicenses.schema.json"><span>cglicenses.schema.json</span></span></a></div></div></div></div></div><div class="monaco-list-row" data-index="3" data-last-element="false" aria-setsize="61" aria-posinset="4" role="treeitem" id="list_id_1_3" aria-label="cgmanifest.schema.json" aria-level="2" draggable="true" style="top: 66px; height: 22px; line-height: 22px;"><div class="monaco-tl-row"><div class="monaco-tl-twistie" style="margin-left: 16px;"></div><div class="monaco-tl-contents"><div class="monaco-icon-label file-icon cgmanifest.schema.json-name-file-icon schema.json-ext-file-icon json-ext-file-icon ext-file-icon json-lang-file-icon explorer-item" title="~/Development/vscode/.vscode/cgmanifest.schema.json" style="display: flex;"><div class="monaco-icon-label-description-container"><a class="label-name"><span class="monaco-highlighted-label" title="~/Development/vscode/.vscode/cgmanifest.schema.json"><span>cgmanifest.schema.json</span></span></a></div></div></div></div></div><div class="monaco-list-row" data-index="4" data-last-element="false" aria-setsize="61" aria-posinset="5" role="treeitem" id="list_id_1_4" aria-label="extensions.json" aria-level="2" draggable="true" style="top: 88px; height: 22px; line-height: 22px;"><div class="monaco-tl-row"><div class="monaco-tl-twistie" style="margin-left: 16px;"></div><div class="monaco-tl-contents"><div class="monaco-icon-label file-icon extensions.json-name-file-icon json-ext-file-icon ext-file-icon jsonc-lang-file-icon explorer-item" title="~/Development/vscode/.vscode/extensions.json" style="display: flex;"><div class="monaco-icon-label-description-container"><a class="label-name"><span class="monaco-highlighted-label" title="~/Development/vscode/.vscode/extensions.json"><span>extensions.json</span></span></a></div></div></div></div></div><div class="monaco-list-row" data-index="5" data-last-element="false" aria-setsize="61" aria-posinset="6" role="treeitem" id="list_id_1_5" aria-label="launch.json" aria-level="2" draggable="true" style="top: 110px; height: 22px; line-height: 22px;"><div class="monaco-tl-row"><div class="monaco-tl-twistie" style="margin-left: 16px;"></div><div class="monaco-tl-contents"><div class="monaco-icon-label file-icon launch.json-name-file-icon json-ext-file-icon ext-file-icon jsonc-lang-file-icon explorer-item" title="~/Development/vscode/.vscode/launch.json" style="display: flex;"><div class="monaco-icon-label-description-container"><a class="label-name"><span class="monaco-highlighted-label" title="~/Development/vscode/.vscode/launch.json"><span>launch.json</span></span></a></div></div></div></div></div></div><div role="presentation" aria-hidden="true" class="invisible scrollbar horizontal" style="position: absolute; width: 0px; height: 0px; left: 0px; bottom: 0px;"><div class="slider" style="position: absolute; top: 0px; left: 0px; height: 10px; will-change: transform; width: 0px;"></div></div><div role="presentation" aria-hidden="true" class="invisible scrollbar vertical fade" style="position: absolute; width: 10px; height: 124px; right: 0px; top: 0px;"><div class="slider" style="position: absolute; top: 0px; left: 0px; width: 10px; will-change: transform; height: 20px;"></div></div><div class="shadow"></div><div class="shadow"></div><div class="shadow top-left-corner"></div></div><style type="text/css" media="screen"></style><div class="monaco-list-type-filter-message"></div></div>
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Jan 23, 2019
@isidorn isidorn added this to the December/January 2019 milestone Jan 23, 2019
@isidorn
Copy link
Contributor Author

isidorn commented Jan 23, 2019

Upon further inspection it seems like the tree is actually thinking it has less space than it actually has.
Note that I have verified that I pass the correct layout to the tree, so I pass around 1000px and the tree takes only around 210 px.

screenshot 2019-01-23 at 11 07 42

@joaomoreno
Copy link
Member

This repros for me just by zooming in once in Linux. What.

@joaomoreno
Copy link
Member

OK now it's gone. What.

@joaomoreno
Copy link
Member

joaomoreno commented Jan 23, 2019

This was reproducing 100% of the time, even across reloads, with a single zoom in... until the moment I hid and showed the side bar. Now it simply does not repro at all even across reloads. 😕

@joaomoreno
Copy link
Member

Nasty nasty bug!

@joaomoreno joaomoreno added the list-widget List widget issues label Jan 23, 2019
@isidorn
Copy link
Contributor Author

isidorn commented Jan 30, 2019

Works great now, verified with the suggest widget.

@isidorn isidorn added the verified Verification succeeded label Jan 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug list-widget List widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants