Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal incremental search doesn't handle shortening search term sometimes #67438

Closed
gregvanl opened this issue Jan 29, 2019 · 1 comment
Closed

Terminal incremental search doesn't handle shortening search term sometimes #67438

gregvanl opened this issue Jan 29, 2019 · 1 comment
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues verified Verification succeeded
Milestone
February 2019

Comments

@gregvanl
Copy link

  • VSCode Version: 1.31 Insiders
  • OS Version: Windows 10

Found during testing of #67307

Steps to Reproduce:

  1. Add "asdfasdf" text to the terminal.
  2. Search for "asdf" and match is found.
  3. Search for "asdfx" and match is not found.
  4. Backspace in search box to remove the 'x' so back to "asdf".

Match is not found. If you then remove 'f', match for "adf" is found.
@vscodebot vscodebot bot added the search Search widget and operation issues label Jan 29, 2019
@kieferrm kieferrm assigned Tyriar and unassigned roblourens Jan 29, 2019
@kieferrm kieferrm added terminal Integrated terminal issues and removed search Search widget and operation issues labels Jan 29, 2019
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities good first issue Issues identified as good for first-time contributors labels Jan 29, 2019
@Tyriar Tyriar added this to the Backlog milestone Jan 29, 2019
@skyway777 skyway777 mentioned this issue Jan 30, 2019
Merged
@skyway777
Copy link

Just created a PR into xterm.js repo

@Tyriar Tyriar modified the milestones: Backlog, February 2019 Feb 2, 2019
@Tyriar Tyriar closed this as completed in 7ed75d9 Feb 2, 2019
@sandy081 sandy081 added the verified Verification succeeded label Feb 26, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Milestone
February 2019
Development

No branches or pull requests
6 participants
@roblourens @Tyriar @skyway777 @kieferrm @sandy081 @gregvanl