Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List highlight filter: when there is one match up/down should traverse all node #67449

Closed
miguelsolorio opened this issue Jan 29, 2019 · 4 comments
Closed

List highlight filter: when there is one match up/down should traverse all node #67449

miguelsolorio opened this issue Jan 29, 2019 · 4 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues verified Verification succeeded
Milestone
February 2019

Comments

@miguelsolorio
Copy link
Contributor

Refs: #66485

Repro

  1. open vscode repo
  2. type node
  3. enable filter on type
  4. Use up/down arrows to navigate to other folders
  5. 馃悰 Can't move around to the other folders

image
@isidorn
Copy link
Contributor

isidorn commented Jan 29, 2019 •
edited

Similar to #66904
So it makes sense that up/down also go through all if there is only one match or less. Forwarding to @joaomoreno unasign yoursel if you agree and you want me to fix this

@isidorn isidorn changed the title Filter on type in explorer doesn't allow you to navigate to other collapsed folders List highlight filter: when there is one match up/down should traverse all node Jan 29, 2019
@isidorn isidorn added this to the December/January 2019 milestone Jan 29, 2019
@joaomoreno
Copy link
Member

I guess we should just keep navigation normal when using filter.

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues labels Jan 29, 2019
@roblourens
Copy link
Member

Is the change that build and resources should be selectable in this case when their children have matches? I don't see that happening.

@roblourens roblourens reopened this Feb 1, 2019
@roblourens roblourens added the verification-found Issue verification failed label Feb 1, 2019
@joaomoreno
Copy link
Member

Yeah... I'll just disable navigation filtering when using filter...

@joaomoreno joaomoreno removed the verification-found Issue verification failed label Feb 3, 2019
@alexr00 alexr00 added the verified Verification succeeded label Feb 26, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues verified Verification succeeded
Projects
None yet
Milestone
February 2019
Development

No branches or pull requests
5 participants
@joaomoreno @roblourens @isidorn @miguelsolorio @alexr00