Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Themes: enabling after installation shows glitch in extension editor #67628

Closed
bpasero opened this issue Jan 31, 2019 · 3 comments
Closed

Themes: enabling after installation shows glitch in extension editor #67628

bpasero opened this issue Jan 31, 2019 · 3 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded webview Webview issues
Milestone
February 2019

Comments

@bpasero
Copy link
Member

bpasero commented Jan 31, 2019 •
edited

Refs #67434

  • OS Version: Ubuntu 18

Steps to Reproduce:

  1. be on a light theme
  2. find the "Nord" theme
  3. click the install button directly (do not open theme first)
  4. 馃悰 the workbench switches to the theme but the extension editor stays white

peek 2019-01-31 09-38
@bpasero bpasero added the themes Color theme issues label Jan 31, 2019
@bpasero bpasero mentioned this issue Jan 31, 2019
Closed
@sandy081 sandy081 added this to the December/January 2019 milestone Jan 31, 2019
@aeschli aeschli removed their assignment Jan 31, 2019
@sandy081 sandy081 removed this from the December/January 2019 milestone Jan 31, 2019
@sandy081 sandy081 added webview Webview issues and removed themes Color theme issues labels Jan 31, 2019
@sandy081
Copy link
Member

@bpasero I cannot repro it.

Even though it repros I suspect, probably a timing issue or web view is not handling it correctly.

@sandy081 sandy081 assigned mjbvz and unassigned sandy081 Jan 31, 2019
@mjbvz mjbvz added this to the February 2019 milestone Feb 1, 2019
@mjbvz
Copy link
Contributor

mjbvz commented Feb 1, 2019

Yes, timing related since it only happens sometimes in my testing

@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Feb 1, 2019
@mjbvz
Copy link
Contributor

mjbvz commented Feb 1, 2019

I tested my fix by reverting 65cc37a. If we don't ship with auto theme enablement, I'm not sure this bug is relevant anymore (but this race could technically be hit in other flows as well)

@mjbvz mjbvz closed this as completed in b4165f6 Feb 1, 2019
@bpasero bpasero added the verified Verification succeeded label Feb 25, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded webview Webview issues
Projects
None yet
Milestone
February 2019
Development

No branches or pull requests
4 participants
@bpasero @aeschli @sandy081 @mjbvz