Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile colorizing tests - handling variable expansion in a variable name #67921

Merged
merged 1 commit into from
Feb 6, 2019

Conversation

fadeevab
Copy link
Contributor

@fadeevab fadeevab commented Feb 5, 2019

In the new grammar update, see below, the "$(another-var)" will be highlighted:

var-**$(another-var)** := value

@alexr00 Just in a case if you pull makefile grammatic again, you would need an updated test case here (only additions, only green, grammar update is a backward compatible with old test cases).

Do it only after makefile grammatic update.

… name in assignment: var-$(another-var) := value
@joaomoreno joaomoreno removed their assignment Feb 6, 2019
@alexr00 alexr00 added this to the February 2019 milestone Feb 6, 2019
@alexr00
Copy link
Member

alexr00 commented Feb 6, 2019

I pulled in the grammar changes again. Thank you for the test update!

@alexr00 alexr00 merged commit da82ae4 into microsoft:master Feb 6, 2019
@fadeevab fadeevab deleted the makefile-update branch April 13, 2019 13:22
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants