Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: findFiles ignores files listed in search.exclude #68056

Closed
joaomoreno opened this issue Feb 7, 2019 · 3 comments
Closed

API: findFiles ignores files listed in search.exclude #68056

joaomoreno opened this issue Feb 7, 2019 · 3 comments
Assignees
@roblourens
Labels
api bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Milestone
February 2019

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Feb 7, 2019 •
edited

This is a breaking change in the current insiders d9f81c8. Does not reproduce in our latest stable 1.31.0.

Using the findFiles API, the latest Insiders decided to start respecting the search.exclude setting.

I've found the issue because the Mocha Test Explorer simply does not work any more on the latest Insiders, when using it on the VSCE repo which, understandably, excludes out/** from search, since all generated code ends up in there. But now, the extension can't find the tests any more, because they are all inside that folder.

cc @jrieken
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug api labels Feb 7, 2019
@joaomoreno
Copy link
Member Author

cc @hbenl

@jrieken jrieken added the important Issue identified as high-priority label Feb 7, 2019
@roblourens roblourens added this to the February 2019 milestone Feb 7, 2019
@sandy081 sandy081 added verified Verification succeeded verification-found Issue verification failed and removed verified Verification succeeded labels Feb 26, 2019
@sandy081
Copy link
Member

@roblourens I still do not see the tests populated in the test explorer which works correctly in stable. Hence reopening.

@sandy081 sandy081 reopened this Feb 26, 2019
@roblourens
Copy link
Member

Oh and .gitignore...

@RMacfarlane RMacfarlane added verified Verification succeeded and removed verification-found Issue verification failed labels Feb 27, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
api bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Milestone
February 2019
Development

No branches or pull requests
5 participants
@joaomoreno @roblourens @jrieken @RMacfarlane @sandy081