Cmd+F Not searching in selection broken

[roubaobaozi]

Issue Type: Bug

Cmd + F (Find) has gotten worse. Deselecting “search in selection” still only searches in selection, have to select entire document and select “search in selection” to get it to work. Since last update.

VS Code version: Code 1.31.0 (7c66f58, 2019-02-05T22:32:14.164Z)
OS version: Darwin x64 17.7.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization: enabled surface_synchronization: enabled_on video_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	3, 5, 5
Memory (System)	16.00GB (0.08GB free)
Process Argv	-psn_0_1323331
Screen Reader	no
VM	0%

Extensions (23)

Extension	Author (truncated)	Version
autofilename	Jer	0.1.3
alignment	ann	0.3.0
snapshot-tools	asv	0.2.2
vscode-eslint	dba	1.8.0
gitlens	eam	9.5.0
EditorConfig	Edi	0.12.8
vsc-material-theme	Equ	2.6.3
sass-lint	gle	1.0.4
vscode-styled-components	jpo	0.0.25
sort-selection-concentrically	min	1.0.0
prettify-json	moh	0.0.3
mssql	ms-	1.4.0
sublime-keybindings	ms-	4.0.0
vetur	oct	0.14.5
partial-diff	ryu	1.4.0
code-settings-sync	Sha	3.2.4
stylelint	shi	0.48.0
vscode-fileutils	sle	2.13.5
code-spell-checker	str	1.6.10
sort-lines	Tyr	1.8.0
twig	wha	1.0.2
vscode-import-cost	wix	2.12.0
ReactSnippets	xab	2.3.0

[mysticatea]

I have encountered this bug, too. I'm on Windows 7 pro.

"Find in selection" button is broken.

[mysticatea]

This is still problem in vscode 1.31.1 (1b8e830).

I'm worried if this regression bug that was introduced since 1.31.0 has been overlooked because January 2019 Recovery doesn't include this issue.

[rebornix]

The regression was introduced in f9775c5.