Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cloneElementFont Fixes: bpasero comments #68332

Merged

Conversation

cleidigh
Copy link
Contributor

@cleidigh cleidigh commented Feb 9, 2019

Fonts appear correctly inherited now - cannot tell you what happened since I originally used this approach.

Seems foolishly obvious 馃憤

@cleidigh cleidigh requested a review from bpasero February 9, 2019 22:07
@cleidigh cleidigh self-assigned this Feb 9, 2019
@cleidigh cleidigh added dropdown DropDown (SelectBox widget) native and custom issues polish Cleanup and polish issue perf-bloat labels Feb 9, 2019
@bpasero bpasero merged commit 08a4504 into microsoft:master Feb 10, 2019
@bpasero
Copy link
Member

bpasero commented Feb 10, 2019

Awesome.

@bpasero bpasero added this to the February 2019 milestone Feb 10, 2019
@cleidigh cleidigh deleted the selectbox-clone-element-font/removal branch February 10, 2019 23:46
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dropdown DropDown (SelectBox widget) native and custom issues perf-bloat polish Cleanup and polish issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants