⌘R chords not working, when integrated terminal has focus

[avxkim]

It's present in insiders build.

• VSCode Version: 1.31
• OS Version: OSX 10.14.2

Steps to Reproduce:

Open integrated terminal and focus it, then use chords ⌘R, Shift+R => you'll see it doesn't open available scripts from package.json. It stucks on ⌘R was pressed. Waiting for second key of chord..., then i press Shift+R and it just prints "R" in a terminal.

As you can see from a screenshot, i don't have anything else mapped on ⌘R and When condition is empty, so it should work when integrated terminal has focus, but it doesn't. It's been working in a previous version, but not in 1.31.

Does this issue occur when all extensions are disabled?: Yes/No

[usernamehw]

You probably need to add command Id to the skipShell commands in Settings:

https://code.visualstudio.com/docs/editor/integrated-terminal#_forcing-key-bindings-to-pass-through-the-terminal

[avxkim]

Just found an issue with this approach: #63271
Also i have to add all of these lines to my settings.json:

- editor.action.toggleTabFocusMode
- workbench.action.debug.continue
- workbench.action.debug.pause
- workbench.action.debug.restart
- workbench.action.debug.run
- workbench.action.debug.start
- workbench.action.debug.stepInto
- workbench.action.debug.stepOut
- workbench.action.debug.stepOver
- workbench.action.debug.stop
- workbench.action.firstEditorInGroup
- workbench.action.focusActiveEditorGroup
- workbench.action.focusEighthEditorGroup
- workbench.action.focusFifthEditorGroup
- workbench.action.focusFirstEditorGroup
- workbench.action.focusFourthEditorGroup
- workbench.action.focusLastEditorGroup
[...]

Can't i just add one single line, or i'm forced to add every default setting?

I've added it this way:

{
    "workbench.colorTheme": "Monokai",
    "terminal.integrated.commandsToSkipShell": [
        "npm-script.run"
    ]
}

Won't i mess up my other settings?

[usernamehw]

• editor.action.toggleTabFocusMode
• workbench.action.debug.continue
• workbench.action.debug.pause
• workbench.action.debug.restart
• workbench.action.debug.run
• workbench.action.debug.start
• workbench.action.debug.stepInto
• workbench.action.debug.stepOut
• workbench.action.debug.stepOver
• workbench.action.debug.stop
• workbench.action.firstEditorInGroup
• workbench.action.focusActiveEditorGroup
• workbench.action.focusEighthEditorGroup
• workbench.action.focusFifthEditorGroup
• workbench.action.focusFirstEditorGroup
• workbench.action.focusFourthEditorGroup
• workbench.action.focusLastEditorGroup
  [...]

You don't need to add all these lines.

[avxkim]

@usernamehw they fixed it already?

[usernamehw]

Fixed what, exactly?

These commands excluded by default (the big list)
"terminal.integrated.commandsToSkipShell" from your settings are added to that list.

[avxkim]

@usernamehw i've read, that you needed to paste all these actions in order to override default ones for commandsToSkipShell.

[usernamehw]

That was before vscode 1.31.0.

[Tyriar]

@usernamehw actually improved that 💪 #66179

See the release notes: https://code.visualstudio.com/updates/v1_31#_improvements-to-commandstoskipshell-setting